Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inmemory-exporter] Add extension on LoggerProviderBuilder #4541

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

Changes

  • Adds an extension for registering InMemoryExporter against a LoggerProviderBuilder instance

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team June 2, 2023 16:36
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #4541 (3ce59d7) into main (e67d44e) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
- Coverage   85.58%   85.54%   -0.04%     
==========================================
  Files         320      320              
  Lines       12610    12615       +5     
==========================================
  Hits        10792    10792              
- Misses       1818     1823       +5     
Impacted Files Coverage Δ
...rter.InMemory/InMemoryExporterLoggingExtensions.cs 66.66% <50.00%> (-23.34%) ⬇️

... and 5 files with indirect coverage changes

@utpilla
Copy link
Contributor

utpilla commented Jun 2, 2023

Update the PR title.

@CodeBlanch CodeBlanch changed the title [console-exporter] Add extension on LoggerProviderBuilder [inmemory-exporter] Add extension on LoggerProviderBuilder Jun 2, 2023
@CodeBlanch CodeBlanch merged commit b9a0138 into open-telemetry:main Jun 3, 2023
@CodeBlanch CodeBlanch deleted the consoleexporter-loggerproviderbuilder-extension branch June 3, 2023 00:10
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants