[di] Expose a detached LoggerProviderBuilder extension on IServiceCollection which may modify services #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on which may modify services.
CodeBlanch
commented
May 31, 2023
| /// </summary> | ||
| internal sealed class LoggerProviderServiceCollectionBuilder : LoggerProviderBuilder, ILoggerProviderBuilder | ||
| internal sealed class LoggerProviderBuilderBase : LoggerProviderBuilder, ILoggerProviderBuilder |
There was a problem hiding this comment.
Originally when this was added you commented that you would prefer it was named LoggerProviderBuilderBase so it matched tracing & metrics. Just FYI it ended up being exactly that 😄
CodeBlanch
commented
May 31, 2023
Comment on lines
+5
to
+10
| * Added an `IServiceCollection.ConfigureOpenTelemetryMeterProvider` overload | ||
| which may be used to configure `MeterProviderBuilder`s while the | ||
| `IServiceCollection` is modifiable (before the `IServiceProvider` has been | ||
| created). | ||
| ([#4517](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4517)) | ||
|
|
There was a problem hiding this comment.
Merge issue from #4517
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4531 +/- ##
==========================================
+ Coverage 85.31% 85.38% +0.07%
==========================================
Files 319 320 +1
Lines 12634 12647 +13
==========================================
+ Hits 10779 10799 +20
+ Misses 1855 1848 -7
|
utpilla
approved these changes
May 31, 2023
alanwest
approved these changes
Jun 1, 2023
53 tasks
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
…lection which may modify services (open-telemetry#4531) Co-authored-by: Alan West <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4517
Changes
IServiceCollection.ConfigureOpenTelemetryLoggerProviderextension which doesn't requireIServiceProviderand allows forIServiceCollectionmodification.Merge requirement checklist