Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-logs] LogRecord LogLevel/Severity conversion test #4462

Merged
merged 1 commit into from
May 4, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented May 4, 2023

Relates to #4433
Relates to #4456

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team May 4, 2023 21:33
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #4462 (7bbdd63) into main (88e8439) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4462      +/-   ##
==========================================
+ Coverage   83.28%   83.34%   +0.05%     
==========================================
  Files         314      314              
  Lines       12523    12524       +1     
==========================================
+ Hits        10430    10438       +8     
+ Misses       2093     2086       -7     
Impacted Files Coverage Δ
src/OpenTelemetry/Logs/LogRecord.cs 67.14% <100.00%> (+4.55%) ⬆️

... and 1 file with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 8f4d83a into open-telemetry:main May 4, 2023
@CodeBlanch CodeBlanch deleted the sdk-logs-logleveltest branch May 4, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants