Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-logs] Add LoggerProviderBuilderExtensions to SDK #4450

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #4433

Changes

  • Adds LoggerProviderBuilderExtensions to SDK.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team April 27, 2023 17:39
@CodeBlanch CodeBlanch changed the title Add LoggerProviderBuilderExtensions to SDK. [sdk-logs] Add LoggerProviderBuilderExtensions to SDK Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #4450 (3caf19a) into main (19b666e) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

❗ Current head 3caf19a differs from pull request most recent head 3d53fd7. Consider uploading reports for the commit 3d53fd7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4450      +/-   ##
==========================================
- Coverage   84.42%   84.07%   -0.36%     
==========================================
  Files         310      311       +1     
  Lines       12281    12329      +48     
==========================================
- Hits        10368    10365       -3     
- Misses       1913     1964      +51     
Impacted Files Coverage Δ
...ry/Logs/Builder/LoggerProviderBuilderExtensions.cs 0.00% <0.00%> (ø)
...Telemetry/Logs/Builder/LoggerProviderBuilderSdk.cs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 1b9290e into open-telemetry:main Apr 27, 2023
@CodeBlanch CodeBlanch deleted the sdk-logs-builderextensions branch April 27, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants