Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP Exporter] Revert Google.Protobuf version bump #4407

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

alanwest
Copy link
Member

Reverts #4201 based on discussion and proposal here #4396 (comment)

@alanwest alanwest requested a review from a team April 19, 2023 17:51
@alanwest alanwest changed the title Revert Google.Protobuf version bump [OTLP Exporter] Revert Google.Protobuf version bump Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #4407 (0720829) into main (9d2c31a) will decrease coverage by 0.09%.
The diff coverage is 96.66%.

❗ Current head 0720829 differs from pull request most recent head 70ba52f. Consider uploading reports for the commit 70ba52f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
- Coverage   84.91%   84.83%   -0.09%     
==========================================
  Files         306      300       -6     
  Lines       12154    12092      -62     
==========================================
- Hits        10321    10258      -63     
- Misses       1833     1834       +1     
Impacted Files Coverage Δ
...tryProtocol/Implementation/MetricItemExtensions.cs 86.86% <93.33%> (+0.99%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 96.23% <100.00%> (+0.30%) ⬆️

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants