Sql for .net framework should call Enrich #4161
Conversation
|
|
||
| try | ||
| { | ||
| this.options.Enrich?.Invoke(activity, "OnCustom", eventData.Payload); |
There was a problem hiding this comment.
Is payload useful to anyone? IIRC we didn't add this because it is just an array of a few strings and there was no way to get at the raw request (command object).
There was a problem hiding this comment.
Nothing I am aware of, I cannot think of any reason to use the SqlCommand either, but it encapsulates the same idea as the SqlCommand that is passed from .NET in providing the raw data from with the activity is created from.
There was a problem hiding this comment.
if there is no use case, then we dont need Enrich for .NET framework, right? (thats the current behavior)
There was a problem hiding this comment.
Just because I cannot see a usecase for the 3rd parameter. That doesn't mean there is no usecase at all. E.g. i want the activity.Displayname to be the same no matter what the underlaying db name is.
There was a problem hiding this comment.
to change activity.DisplayName, you can use ActivityProcessor. The whole Enrich feature was provided to provide easy access to raw objects from which users can extract additional information. In case of SQL on .NET FW, the raw object(payload) do not have anything not already parsed out by default.
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlEventSourceListener.netfx.cs
Show resolved
Hide resolved
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #4080
Changes
Call Enrich in the approximately the same place for .net framework as in .net.
Update docs to fix naming of .nets
Update docs to mention the difference in 3rd parameter.