Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrics branch] Add configuration of persistent storage to OTLP Exporter #4121

Closed
wants to merge 59 commits into from
Closed

[metrics branch] Add configuration of persistent storage to OTLP Exporter #4121

wants to merge 59 commits into from

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jan 31, 2023 •
edited
Loading

Towards #4115

Changes

  • Adds PersistentBlobProvider to Base OTLP gRPC Export Client that does nothing currently. Added a TODO which will be updated to conditionally write to disk retryable errors to be done in the next PR.
  • Update console example program to use it
  • Note: Only adding via the extension method, not from the OtlpExporter ctor

Screenshot showing OTLP example program running and the file it creates.
image

@mic-max mic-max changed the base branch from main to main-metrics January 31, 2023 08:00
@mic-max mic-max marked this pull request as ready for review January 31, 2023 08:01
@mic-max mic-max requested a review from a team January 31, 2023 08:01
@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Merging #4121 (0df6276) into main-metrics (e6efd4d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 0df6276 differs from pull request most recent head 38c8e93. Consider uploading reports for the commit 38c8e93 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           main-metrics    #4121      +/-   ##
================================================
+ Coverage         84.61%   84.75%   +0.13%     
================================================
  Files               296      296              
  Lines             11549    11515      -34     
================================================
- Hits               9772     9759      -13     
+ Misses             1777     1756      -21
Impacted Files Coverage Δ
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs 85.71% <100.00%> (+1.50%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 93.33% <100.00%> (+0.47%) ⬆️
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 96.42% <100.00%> (+0.06%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 70.83% <0.00%> (-4.17%) ⬇️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 96.07% <0.00%> (-0.59%) ⬇️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 96.49% <0.00%> (-0.48%) ⬇️
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 0.00% <0.00%> (ø)
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
...lemetry/Metrics/Builder/MeterProviderBuilderSdk.cs 86.88% <0.00%> (ø)
...xemplar/AlignedHistogramBucketExemplarReservoir.cs 0.00% <0.00%> (ø)
... and 4 more

@mic-max mic-max marked this pull request as draft February 1, 2023 19:38
@mic-max mic-max changed the title OTLP Exporter: Add options for PersistentStorage Write retryable errors to disk using PersistentStorage from OtlpGrpcTraceExportClient Feb 4, 2023
@mic-max mic-max marked this pull request as ready for review February 4, 2023 11:10
@mic-max mic-max marked this pull request as draft February 9, 2023 00:11
@CodeBlanch CodeBlanch mentioned this pull request Feb 16, 2023
Merged
mic-max and others added 11 commits February 16, 2023 13:35
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 25, 2023
vishweshbankwar
vishweshbankwar approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall direction looks good.

rajkumar-rangaraj
rajkumar-rangaraj approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This approach may not work for logs, but we could extend this for metrics. As OTLP logs exporter is not stable we could later explore alternate approach.

@cijothomas cijothomas deleted the branch open-telemetry:main-metrics February 27, 2023 23:58
@cijothomas cijothomas closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@reyang reyang reyang left review comments

@cijothomas cijothomas cijothomas left review comments

@alanwest alanwest alanwest left review comments

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@Yun-Ting Yun-Ting Yun-Ting approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mic-max @alanwest @cijothomas @rajkumar-rangaraj @Yun-Ting @reyang @vishweshbankwar @CodeBlanch