Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ImplicitUsings disable from projects (part 8) #3993

Merged
merged 10 commits into from
Dec 8, 2022
Merged

remove ImplicitUsings disable from projects (part 8) #3993

merged 10 commits into from
Dec 8, 2022

Conversation

TimothyMothra
Copy link
Contributor

Towards #3958.
Follow up to #3959.

In my previous PR, I enabled ImplicitUsings in Common.props and disabled this in projects with errors.
This PR fixes some projects and turns ImplicitUsings back on.

Changes

  • remove #pragma warning disable IDE0005 introduced in previous PRs
  • remove ImplicitUsings disable from projects
    • OpenTelemetry
    • OpenTelemetry.Api

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team December 8, 2022 21:52
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3993 (69ec486) into main (ab3e407) will increase coverage by 85.56%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #3993       +/-   ##
=========================================
+ Coverage      0   85.56%   +85.56%     
=========================================
  Files         0      288      +288     
  Lines         0    11070    +11070     
=========================================
+ Hits          0     9472     +9472     
- Misses        0     1598     +1598     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Baggage.cs 100.00% <ø> (ø)
src/OpenTelemetry.Api/BaseProvider.cs 100.00% <ø> (ø)
...emetry.Api/Context/AsyncLocalRuntimeContextSlot.cs 75.00% <ø> (ø)
...nTelemetry.Api/Context/Propagation/B3Propagator.cs 85.86% <ø> (ø)
...metry.Api/Context/Propagation/BaggagePropagator.cs 85.48% <ø> (ø)
.../Context/Propagation/CompositeTextMapPropagator.cs 83.33% <ø> (ø)
...y.Api/Context/Propagation/NoopTextMapPropagator.cs 0.00% <ø> (ø)
...etry.Api/Context/Propagation/PropagationContext.cs 64.28% <ø> (ø)
....Api/Context/Propagation/TraceContextPropagator.cs 87.64% <ø> (ø)
...etry.Api/Context/Propagation/TraceStateUtilsNew.cs 83.00% <ø> (ø)
... and 395 more

@utpilla utpilla merged commit 6fa6700 into open-telemetry:main Dec 8, 2022
@TimothyMothra TimothyMothra deleted the 3958_usings8 branch December 8, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants