Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Add net.peer.name and net.peer.port on metric dimensions #3907

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 15, 2022

Towards #3373

Changes

Added dimensions as per spec

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar changed the title Add net.peer.name and net.peer.port on metric [HttpClient] Add net.peer.name and net.peer.port on metric dimensions Nov 15, 2022
@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 15, 2022 19:19
@vishweshbankwar vishweshbankwar requested a review from a team November 15, 2022 19:19
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #3907 (a18df16) into main (a758c60) will decrease coverage by 0.12%.
The diff coverage is 55.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3907      +/-   ##
==========================================
- Coverage   87.35%   87.23%   -0.13%     
==========================================
  Files         279      279              
  Lines       10781    10792      +11     
==========================================
- Hits         9418     9414       -4     
- Misses       1363     1378      +15     
Impacted Files Coverage Δ
...ementation/HttpHandlerMetricsDiagnosticListener.cs 70.00% <55.55%> (-24.74%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-10.00%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 2e7b7a9 into open-telemetry:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants