Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Fix few tests #3906

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar requested a review from a team November 15, 2022 17:41
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #3906 (a7381aa) into main (f770047) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
+ Coverage   87.31%   87.32%   +0.01%     
==========================================
  Files         279      279              
  Lines       10781    10781              
==========================================
+ Hits         9413     9415       +2     
+ Misses       1368     1366       -2     
Impacted Files Coverage Δ
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 95.00% <0.00%> (+10.00%) ⬆️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 86.36% <0.00%> (+13.63%) ⬆️

@cijothomas
Copy link
Member

Failed OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.MockCollectorIntegrationTests.TestRecoveryAfterFailedExport [1 s]
Error Message:
Assert.Equal() Failure
Expected: Failure
Actual: Success
Stack Trace:
at OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.MockCollectorIntegrationTests.TestRecoveryAfterFailedExport() in D:\a\opentelemetry-dotnet\opentelemetry-dotnet\test\OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests\MockCollectorIntegrationTests.cs:line 101
--- End of stack trace from previous location ---

@cijothomas cijothomas merged commit a758c60 into open-telemetry:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants