-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sql Instrumentation] Unify exposed public API #3900
[Sql Instrumentation] Unify exposed public API #3900
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3900 +/- ##
==========================================
- Coverage 87.38% 87.31% -0.08%
==========================================
Files 279 279
Lines 10782 10781 -1
==========================================
- Hits 9422 9413 -9
- Misses 1360 1368 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/OpenTelemetry.Instrumentation.SqlClient/SqlClientInstrumentationOptions.cs
Show resolved
Hide resolved
@CodeBlanch - Don't we need to keep this information on Readme?
|
Relates to #3793
Changes
Public API Changes
TODOs
CHANGELOG.md
updated for non-trivial changes