Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark numbers and remove invalid case #3848

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

cijothomas
Copy link
Member

Removed the benchmark using CustomProperty. OTel does not use it ever.
Added numbers for quick reference.

@cijothomas cijothomas marked this pull request as ready for review October 31, 2022 17:54
@cijothomas cijothomas requested a review from a team October 31, 2022 17:54
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #3848 (d9cc7f5) into main (131b350) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   87.47%   87.39%   -0.09%     
==========================================
  Files         280      280              
  Lines       10765    10765              
==========================================
- Hits         9417     9408       -9     
- Misses       1348     1357       +9     
Impacted Files Coverage Δ
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 72.72% <0.00%> (-13.64%) ⬇️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (-10.00%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 96.21% <0.00%> (+1.08%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 75.00% <0.00%> (+4.16%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit c154931 into open-telemetry:main Oct 31, 2022
@cijothomas cijothomas deleted the cijothomas/benchmark-fix branch October 31, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants