Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Env from CI DOTNET_MULTILEVEL_LOOKUP = 1 #3779

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Remove Env from CI DOTNET_MULTILEVEL_LOOKUP = 1 #3779

merged 4 commits into from
Oct 18, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Oct 18, 2022

Towards #3014

Remove DOTNET_MULTILEVEL_LOOKUP = 1
I believe it was only needed for .NET Core 3.1 and below

@mic-max mic-max changed the title Remove DOTNET_MULTILEVEL_LOOKUP = 1 Remove Env from CI DOTNET_MULTILEVEL_LOOKUP = 1 Oct 18, 2022
@mic-max mic-max marked this pull request as ready for review October 18, 2022 17:01
@mic-max mic-max requested a review from a team October 18, 2022 17:01
@vishweshbankwar
Copy link
Member

Also

DOTNET_MULTILEVEL_LOOKUP: 1

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3779 (d3390c3) into main (4239992) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d3390c3 differs from pull request most recent head 3665eb5. Consider uploading reports for the commit 3665eb5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3779      +/-   ##
==========================================
+ Coverage   87.35%   87.38%   +0.02%     
==========================================
  Files         277      281       +4     
  Lines       10241    10745     +504     
==========================================
+ Hits         8946     9389     +443     
- Misses       1295     1356      +61     
Impacted Files Coverage Δ
...nTelemetry/Trace/ExportActivityProcessorOptions.cs 40.00% <0.00%> (-10.00%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 73.62% <0.00%> (-2.20%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.13% <0.00%> (-1.09%) ⬇️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 96.73% <0.00%> (-0.99%) ⬇️
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <0.00%> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <0.00%> (ø)
...metry/Trace/BatchExportActivityProcessorOptions.cs 100.00% <0.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <0.00%> (ø)
...trumentation.SqlClient/SqlClientInstrumentation.cs 100.00% <0.00%> (ø)
...umentation.Http/TracerProviderBuilderExtensions.cs 100.00% <0.00%> (ø)
... and 23 more

@mic-max
Copy link
Contributor Author

mic-max commented Oct 18, 2022

Also

DOTNET_MULTILEVEL_LOOKUP: 1

Thanks! I guess I can't trust VS search and should double check with GitHub search 😅

@reyang
Copy link
Member

reyang commented Oct 18, 2022

Thanks! I guess I can't trust VS search and should double check with GitHub search 😅

Don't trust GitHub search 😺

@vishweshbankwar
Copy link
Member

Thanks! I guess I can't trust VS search and should double check with GitHub search 😅

Don't trust GitHub search 😺

I use VS Code :)

@cijothomas cijothomas merged commit fa950b3 into open-telemetry:main Oct 18, 2022
@mic-max mic-max deleted the ci-changes branch October 18, 2022 22:25
CodeBlanch added a commit that referenced this pull request Oct 24, 2022
* [Logs] Fix buffered log scopes being reused (#3731)

* Fix buffered log scopes being reused.

* CHANGELOG update.

* Test fixes.

Co-authored-by: Cijo Thomas <[email protected]>

* clarify that Prometheus HttpListner is not for production at this moment (#3737)

* [HttpClient] Export spans corresponding to retries (#3732)

* Minor update to OTLP readme (#3739)

* Nit fixes to prometheus readme

* Add minor clarification about OTLP logs

* Update workflow (#3741)

* Minor improvement to log message (#3742)

* [SDK + Jaeger] Support loading environment variables from IConfiguration in Traces & Metrics (#3720)

* Support retrieval of environment variables through IConfiguration in SDK.

* Update Jaeger to load environment variables through IConfiguration.

* Warning fix.

* CHANGELOG patch.

* Bug fixes.

* Warning cleanup.

* Code review.

* [Zipkin] Support loading envvars from IConfiguration (#3759)

* Support loading envvars from IConfiguration in Zipkin exporter.

* CHANGELOG patch.

* SqlClient Instrumentation to leverage native Activity Status. (#3751)

* [Metrics] Update default buckets for Explicit Bucket Histogram from spec (#3722)

* [Logs] Fix: Respect AttributeValueLengthLimit when building otlp LogRecord data (#3684)

* Respect SdkConfiguration.AttributeValueLengthLimit so otlp data points are not rejected by monitoring tools

* Respect maxAttributeCount and use OtlpKeyValueTransformer in AddStringAttribute and in AddIntAttribute

* Extend CHANGELOG.md

Co-authored-by: Mikel Blanchard <[email protected]>

* Bump actions/setup-dotnet from 3.0.1 to 3.0.2 (#3764)

Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Repo] Attempting to stabilize the API Compatibility CI job (#3766)

* Attempting to stablize the API Compatibility CI.

* Tweak.

* More logging.

* Increase build logging level for api compat ci job.

* Tweak.

* Tweak.

* Revert extra logging in ci job.

* Switched some logging back to debug.

* Adding MinMax to Histograms (#2735)

* Logging state during building of TracerProvider (#3746)

* [HttpClient] Add unit tests for `RecordException` case (#3761)

* Add a separate example project for Logs redaction (#3744)

* Update CHANGELOG for 1.4.0-beta.2 release (#3772)

* [SDK + Otlp] Support loading envvars from IConfiguration (#3760)

* Updated Otlp Trace & Metrics exporters to load envvars from IConfiguration.

* Patch CHANGELOGs.

* Fix up otlp log exporter for SdkOptions changes.

* Revert SdkOptions public api.

* Restore tests.

* Fix benchmarks.

* SdkLimitOptions IConfiguration test.

* OtlpExporterOptions IConfiguration test.

* MetricReaderOptions IConfiguration test.

* Bug fix.

* Nit.

* [SqlClient] Add support for Filter expression (#3743)

* [SDK, Jaeger, Zipkin, & Otlp] Support loading envvars for BatchExportActivityProcessorOptions from IConfiguration (#3776)

* Support loading envvars for ExportActivityProcessorOptions & BatchExportActivityProcessorOptions from IConfiguration.

* Update src/OpenTelemetry/CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Patch CHANGELOG.

* Unit test.

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>

* Remove Env from CI `DOTNET_MULTILEVEL_LOOKUP = 1` (#3779)

* Link to .NET docs about different ports (#3704)

* Update DS to rc2 (#3781)

* ConsoleLogExporter to output full exception (#3784)

* [ASP.NET Core] Add back netstandard2.0 and 2.1 targets (#3755)

* [HttpClient] Add back netstandard2.0 target (#3787)

* Add back netstandard2.0 target

* changelog

* public api files

* Bump System.Text.Json version due to CVE-2021-26701 (#3789)

* Auto-generated Semantic Conventions (#2069)

* [SDK] Support dependency injection in ResourceBuilder and load envvars from IConfiguration (#3782)

* Add Vishwesh as an Approver (#3783)

Co-authored-by: Cijo Thomas <[email protected]>

* Move more SDK docs to docs folder (#3794)

* [Prometheus AspNetCore] Support named options in pipeline extensions (#3780)

* Support named options in Prometheus AspNetCore pipeline extensions.

* Patch CHANGELOG.

Co-authored-by: Cijo Thomas <[email protected]>

* [Logs] UnitTest: LogRecord attribute limits (#3758)

* Unittest for LogRecord attribute limits

* Remove maxValueLength from LogRecordExtensions.AddIntAttribute.

Change requested from #3684 (comment)

* Pr commits addressed

Co-authored-by: Mikel Blanchard <[email protected]>

* Add MinMax to console and doc additions (#3795)

* Mark private and internal classes as sealed (#3799)

Co-authored-by: Cijo Thomas <[email protected]>

* Move more docs to docs folder (#3801)

* [ASP.NET Core] Update enrich callbacks to use specific type. (#3749)

* [Http] Update enrich callbacks for http (#3792)

* [SDK] Support dependency injection in the GetDefaultResource API (#3798)

* Support dependency injection in the GetDefaultResource API.

* CHANGELOG patch.

* Test tweaks.

Co-authored-by: Cijo Thomas <[email protected]>

* Fix circular reference issue building up tracer provider. (#3803)

* [SDK] Add some missing nullable annotations (#3796)

* Added some missing nullable annotations in SDK.

* Handle null span names in SamplingParameters.

* Warning cleanup.

* Warning cleanup.

* Added link to issue in comment.

Co-authored-by: Alan West <[email protected]>

* Guard.Range now uses invariant culture for error message (#3778)

Co-authored-by: Utkarsh Umesan Pillai <[email protected]>

* Fix circular reference issue building up meter provider. (#3806)

Co-authored-by: Utkarsh Umesan Pillai <[email protected]>

* Add missing end of code block backticks (#3807)

* More doc tweaks (#3805)

* More doc tweaks

* remove draft staatus

* Update grpc client enrich callbacks (#3804)

* Port refactor from main-logs branch. (#3808)

Co-authored-by: Cijo Thomas <[email protected]>

* Merge fixes.

* Merge fixes.

* Merge fix.

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Co-authored-by: Vishwesh Bankwar <[email protected]>
Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Yun-Ting Lin <[email protected]>
Co-authored-by: Sebastian Schoder Moreno <[email protected]>
Co-authored-by: Jonathan Wilhelm <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Maxwell <[email protected]>
Co-authored-by: ggoel <[email protected]>
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Co-authored-by: Pavel Steinl <[email protected]>
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Co-authored-by: aristotelos <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Alan West <[email protected]>
Co-authored-by: benhall_io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants