Reduce InternalsVisibleTo #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
reviewed
Oct 4, 2022
| [assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Prometheus.AspNetCore" + AssemblyInfo.PublicKey)] | ||
| [assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests" + AssemblyInfo.PublicKey)] | ||
| [assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Prometheus.HttpListener" + AssemblyInfo.PublicKey)] | ||
| [assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Prometheus.HttpListener.Tests" + AssemblyInfo.PublicKey)] |
There was a problem hiding this comment.
Can we remove tests too or no?
There was a problem hiding this comment.
Tried and they have dependency on MeterProvider.TryFindExporter.
There was a problem hiding this comment.
This is the test code which makes use of the internals
This is where the internal method is defined
There was a problem hiding this comment.
Could probably have a reflection-based alternative for tests.
Looks like PrometheusExporterMiddleware also uses this.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3726 +/- ##
==========================================
+ Coverage 87.19% 87.26% +0.06%
==========================================
Files 274 274
Lines 10009 10009
==========================================
+ Hits 8727 8734 +7
+ Misses 1282 1275 -7
|
TimothyMothra
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reduce the scope of
InternalsVisibleTo, ideally the SDK should not leave any backdoor for exporters.