Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.PrometheusAspNetCore] update Public API #3717

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 30, 2022

Public API changes from #3694 proposed by @CodeBlanch.

Changes

It will allow us to add more properties later for all Prometheus exporters.
There is no stable release for this package, so it should be fine to adjust class name.

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek force-pushed the prometheusaspnetcore-exporter-update-public-api branch from 00c7fab to 2506e06 Compare September 30, 2022 19:40
@Kielek Kielek marked this pull request as ready for review September 30, 2022 19:41
@Kielek Kielek requested a review from a team September 30, 2022 19:41
@Kielek Kielek changed the title Prometheusaspnetcore exporter update public api [Exporter.PrometheusAspNetCore] update Public API Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #3717 (c2de65b) into main (6b38ed7) will decrease coverage by 0.23%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3717      +/-   ##
==========================================
- Coverage   87.32%   87.08%   -0.24%     
==========================================
  Files         274      275       +1     
  Lines       10009    10012       +3     
==========================================
- Hits         8740     8719      -21     
- Misses       1269     1293      +24     
Impacted Files Coverage Δ
...HttpListener/Internal/PrometheusExporterOptions.cs 100.00% <ø> (ø)
...ometheus.AspNetCore/PrometheusAspNetCoreOptions.cs 75.00% <75.00%> (ø)
.../PrometheusExporterApplicationBuilderExtensions.cs 100.00% <100.00%> (ø)
...rometheusExporterEndpointRouteBuilderExtensions.cs 100.00% <100.00%> (ø)
...rometheusExporterMeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...etheus.HttpListener/Internal/PrometheusExporter.cs 100.00% <100.00%> (ø)
...theusHttpListenerMeterProviderBuilderExtensions.cs 92.85% <100.00%> (ø)
...heus.HttpListener/PrometheusHttpListenerOptions.cs 100.00% <100.00%> (ø)
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 35.71% <0.00%> (-42.86%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 36.36% <0.00%> (-40.91%) ⬇️
... and 3 more

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek
Copy link
Contributor Author

Kielek commented Oct 4, 2022

@open-telemetry/dotnet-maintainers please check and possibly merge.

@@ -51,5 +52,7 @@ public IReadOnlyCollection<string> UriPrefixes
this.uriPrefixes = value;
}
}

internal PrometheusExporterOptions ExporterOptions { get; } = new();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required.

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion.

@Kielek
Copy link
Contributor Author

Kielek commented Oct 5, 2022

Left a suggestion.

Fixed: db2f4fc

@utpilla utpilla merged commit e826f9d into open-telemetry:main Oct 5, 2022
@Kielek Kielek deleted the prometheusaspnetcore-exporter-update-public-api branch October 5, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants