Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traces] Add named options support to JaegerExporter builder extensions #3656

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 13, 2022

Changes

Applies the named options pattern from #3648 to JaegerExporter.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit Tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 13, 2022 21:29
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3656 (bd34979) into main (a87f8f7) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
- Coverage   87.84%   87.70%   -0.14%     
==========================================
  Files         283      283              
  Lines       10240    10243       +3     
==========================================
- Hits         8995     8984      -11     
- Misses       1245     1259      +14     
Impacted Files Coverage Δ
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 97.82% <100.00%> (+0.15%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 50.00% <0.00%> (-28.58%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 59.09% <0.00%> (-18.19%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 91.75% <0.00%> (-3.30%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-2.23%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

@CodeBlanch CodeBlanch merged commit cb2eeb5 into open-telemetry:main Sep 13, 2022
@CodeBlanch CodeBlanch deleted the jaeger-namedoptions branch September 13, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants