Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AspNetCore/Http Instrumentation to leverage native Activity Status. #3555

Merged
merged 9 commits into from
Aug 10, 2022
Merged

AspNetCore/Http Instrumentation to leverage native Activity Status. #3555

merged 9 commits into from
Aug 10, 2022

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Aug 5, 2022

Related to #3118

@Yun-Ting Yun-Ting changed the title [Do not merge] AspNetCore Instrumentation to leverage native Activity Status. [Do not merge] AspNetCore/Http Instrumentation to leverage native Activity Status. Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited
Loading

Codecov Report

Merging #3555 (873cb04) into main (b8385a8) will increase coverage by 0.13%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3555      +/-   ##
==========================================
+ Coverage   87.23%   87.37%   +0.13%     
==========================================
  Files         278      278              
  Lines       10083    10082       -1     
==========================================
+ Hits         8796     8809      +13     
+ Misses       1287     1273      -14
Impacted Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 72.34% <42.85%> (-0.30%) ⬇️
src/OpenTelemetry.Api/Internal/SpanHelper.cs 100.00% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.87% <100.00%> (ø)
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 94.50% <0.00%> (+3.29%) ⬆️
... and 3 more

@Yun-Ting Yun-Ting marked this pull request as ready for review August 5, 2022 23:04
@Yun-Ting Yun-Ting requested a review from a team August 5, 2022 23:04
@Yun-Ting Yun-Ting changed the title [Do not merge] AspNetCore/Http Instrumentation to leverage native Activity Status. AspNetCore/Http Instrumentation to leverage native Activity Status. Aug 5, 2022
cijothomas
cijothomas approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add changelog entry too

@Yun-Ting
Copy link
Contributor Author

please add changelog entry too

Updated http and aspnetcore instrumentation changelogs.

@cijothomas cijothomas merged commit dd88099 into open-telemetry:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yun-Ting @cijothomas @vishweshbankwar