Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Bucket Histogram - part 9 #3553

Merged
merged 9 commits into from
Aug 5, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 5, 2022

Following #3462.

Changes

  • Added support for older runtime versions (< net6.0) by rewriting to logic to avoid Math.ScaleB, Math.IsNegative and Math.Log2 dependency.
  • Added more tests.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #3553 (2d3eae4) into main (6205879) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
+ Coverage   86.95%   87.32%   +0.37%     
==========================================
  Files         275      275              
  Lines        9959     9959              
==========================================
+ Hits         8660     8697      +37     
+ Misses       1299     1262      -37     
Impacted Files Coverage Δ
...penTelemetry/Metrics/ExponentialBucketHistogram.cs 78.26% <100.00%> (+13.04%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-2.95%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+4.39%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 100.00% <0.00%> (+21.05%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
... and 1 more

@reyang reyang changed the title [Not Ready for Review] Exponential Bucket Histogram - part 9 Exponential Bucket Histogram - part 9 Aug 5, 2022
@reyang reyang marked this pull request as ready for review August 5, 2022 20:10
@reyang reyang requested a review from a team August 5, 2022 20:10
@utpilla utpilla merged commit ce99d44 into open-telemetry:main Aug 5, 2022
@reyang reyang deleted the reyang/exp9 branch August 5, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants