Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Bucket Histogram - part 5 #3482

Merged
merged 7 commits into from
Jul 25, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 24, 2022

Following #3462.

Changes

  • Implemented in-place scale down algorithm for circular-buffer backed buckets. With this change, the automatic dynamic range adjustment feature is done.

reyang added 4 commits July 22, 2022 19:17

Verified

This commit was signed with the committer’s verified signature.
cotes2020 Cotes Chung
@reyang reyang requested a review from a team July 24, 2022 14:55
@reyang
Copy link
Member Author

reyang commented Jul 24, 2022

Linux / build-test (netcoreapp3.1) stability issue:

image

@reyang reyang closed this Jul 24, 2022
@reyang reyang reopened this Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #3482 (596214a) into main (a55e339) will decrease coverage by 0.07%.
The diff coverage is 70.73%.

❗ Current head 596214a differs from pull request most recent head b3a812c. Consider uploading reports for the commit b3a812c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
- Coverage   86.40%   86.32%   -0.08%     
==========================================
  Files         270      270              
  Lines        9790     9865      +75     
==========================================
+ Hits         8459     8516      +57     
- Misses       1331     1349      +18     
Impacted Files Coverage Δ
...penTelemetry/Metrics/ExponentialBucketHistogram.cs 45.83% <0.00%> (-12.07%) ⬇️
src/OpenTelemetry/Internal/MathHelper.cs 84.44% <50.00%> (-7.45%) ⬇️
src/OpenTelemetry/Metrics/CircularBufferBuckets.cs 91.30% <87.09%> (-8.70%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+1.09%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️

@reyang reyang closed this Jul 24, 2022
@reyang reyang reopened this Jul 24, 2022
@reyang reyang added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Jul 25, 2022
@reyang reyang closed this Jul 25, 2022
@reyang reyang reopened this Jul 25, 2022
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
@cijothomas cijothomas merged commit 6f2b1a0 into open-telemetry:main Jul 25, 2022
@reyang reyang deleted the reyang/exp5 branch July 25, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants