Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch-depth 0 to make minver work properly #3412

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Jun 28, 2022

CI is failing on #3408 with the following:

CSC : error CS1705: Assembly 'OpenTelemetry.Instrumentation.Runtime' with identity 'OpenTelemetry.Instrumentation.Runtime, Version=1.0.0.1, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c' uses 'OpenTelemetry.Api, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c' which has a higher version than referenced assembly 'OpenTelemetry.Api' with identity 'OpenTelemetry.Api, Version=0.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c' [/home/runner/work/opentelemetry-dotnet/opentelemetry-dotnet/examples/AspNetCore/Examples.AspNetCore.csproj]

This is because minver does not actually version our assemblies for PR builds and builds triggered for pushes to main. For minver to work, we need to set fetch-depth=0.

I suspect this may have some impact on build times... not sure what the overhead of fetching all commits is.

@alanwest alanwest requested a review from a team June 28, 2022 02:19
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3412 (2a63e23) into main (34efdbf) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3412      +/-   ##
==========================================
+ Coverage   86.28%   86.30%   +0.02%     
==========================================
  Files         258      258              
  Lines        9269     9269              
==========================================
+ Hits         7998     8000       +2     
+ Misses       1271     1269       -2     
Impacted Files Coverage Δ
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 1bb36fb into open-telemetry:main Jun 28, 2022
@alanwest alanwest deleted the alanwest/fetch-depth branch June 28, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants