Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable warnings in guard class #3236

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix nullable warnings in guard class #3236

merged 2 commits into from
Apr 29, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Apr 27, 2022

Fixes this warning
image
image

Related open-telemetry/opentelemetry-dotnet-contrib#332

Changes

Made the parameters will null as default values nullable fields.
Added #nullable enable to the file so that I could use nullable fields.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #3236 (81a73c1) into main (0741a9d) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
+ Coverage   85.29%   85.56%   +0.26%     
==========================================
  Files         261      261              
  Lines        9385     9385              
==========================================
+ Hits         8005     8030      +25     
+ Misses       1380     1355      -25     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Internal/Guard.cs 0.00% <ø> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 92.34% <0.00%> (+3.60%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@cijothomas cijothomas merged commit b8aaf1a into open-telemetry:main Apr 29, 2022
@mic-max mic-max deleted the guard-warning-fix branch April 29, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants