Minor tweak to OTLP LogExporter tests #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
commented
Apr 14, 2022
| Assert.Equal(2.99, attribute.Value.DoubleValue); | ||
|
|
||
| attribute = otlpLogRecord.Attributes[2]; | ||
| Assert.Equal("{OriginalFormat}", attribute.Key); |
There was a problem hiding this comment.
For next PR, I will be tweaking exporter to special case this, as that is the behavior of the commonly used logging pattern with "message-templates", when using the ILogger.Log extension methods.
This PR is just preparing the tests to see if this is a good approach to test things..
reyang
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #3178 +/- ##
==========================================
+ Coverage 84.79% 84.82% +0.02%
==========================================
Files 259 259
Lines 9322 9322
==========================================
+ Hits 7905 7907 +2
+ Misses 1417 1415 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests towards #2482