Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for release #3108

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

cijothomas
Copy link
Member

Following the pattern described in #2991 (comment)

@cijothomas cijothomas requested a review from a team March 30, 2022 15:06
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas
Copy link
Member Author

@alanwest need one more approval, to see if the new naming pattern (to undo/limit the damage from previous naming pattern) looks okay

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was personally excited about rc10 since I had one of these as a kid... bummer it didn't work well with semver.

@@ -2,6 +2,10 @@

## Unreleased

## 1.2.0-rc4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're hedging that we don't make it to 10 - let's hope not 😆

@@ -10,7 +10,11 @@

## Unreleased

## 1.0.0-rc10
## 1.0.0-rc9.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to re-up my memory of semver. 👍 this checks out:

Screen Shot 2022-03-30 at 9 17 33 AM

I think 1.0.0-rc9.1 is good for this release. I put in 1.0.0-unstable.1 as a potential proposal in the future, specifically for instrumentation packages. "unstable" being the term the spec uses.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 1.0.0-rc31415926535897932384626... similar to what TeX did.

@cijothomas cijothomas merged commit eaa2e0e into open-telemetry:main Mar 30, 2022
@cijothomas cijothomas deleted the cijothomas/changelog120rc4 branch March 30, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants