-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for release #3108
Update changelog for release #3108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest need one more approval, to see if the new naming pattern (to undo/limit the damage from previous naming pattern) looks okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was personally excited about rc10
since I had one of these as a kid... bummer it didn't work well with semver.
@@ -2,6 +2,10 @@ | |||
|
|||
## Unreleased | |||
|
|||
## 1.2.0-rc4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we're hedging that we don't make it to 10 - let's hope not 😆
@@ -10,7 +10,11 @@ | |||
|
|||
## Unreleased | |||
|
|||
## 1.0.0-rc10 | |||
## 1.0.0-rc9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about 1.0.0-rc31415926535897932384626...
similar to what TeX did.
Following the pattern described in #2991 (comment)