[Part3] Support Activity Status and status description in OTLP Exporter. #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
- Coverage 84.97% 84.82% -0.16%
==========================================
Files 259 259
Lines 9179 9185 +6
==========================================
- Hits 7800 7791 -9
- Misses 1379 1394 +15
|
reyang
reviewed
Mar 28, 2022
reyang
reviewed
Mar 28, 2022
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Reiley Yang <[email protected]>
alanwest
reviewed
Mar 28, 2022
Co-authored-by: Alan West <[email protected]>
alanwest
reviewed
Mar 28, 2022
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
alanwest
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
LGTM. I'd be ok with #3100 (comment) being a follow up if you'd prefer.
reyang
reviewed
Mar 28, 2022
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Mar 28, 2022
cijothomas
reviewed
Mar 29, 2022
cijothomas
reviewed
Mar 29, 2022
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 29, 2022
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 29, 2022
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Show resolved
Hide resolved
cijothomas
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes parts of #2569.
Related to: #3003 and #3073
Background : Please review Console.Exporter where the same logic were exercised: #3061.
Added support for Activity.Status/Description in OTLP.Exporter.
System.Diagnostic.DiagnosticSource version 6.0.0 introduced native support for storing status/description in the Activity itself.
This PR modified the exporter to retrieve status from the newly added fields (Activity.Status and Activity StatusDescription) if they were set.
To maintain backward compatibility, the control flow would fell back to retrieve status from the activity.Tags if the native status/description were not set.
Prior to this PR if Status=Unset then the exporter would set both the status and description. This PR skipped setting status and statusDescription if the Status is Unset. Additionally, added statusDescription only if the Status=Error.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes