[Solution] Update preprocessor directives ahead of System.Diagnostics.DiagnosticSource .NET 7 update #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Source .NET 7 update.
reyang
approved these changes
Mar 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
- Coverage 84.79% 84.77% -0.03%
==========================================
Files 259 259
Lines 9181 9181
==========================================
- Hits 7785 7783 -2
- Misses 1396 1398 +2
|
cijothomas
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I needed to target a local .NET 7 build of System.Diagnostics.DiagnosticSource to benchmark some changes I am working on with the runtime team. There were some surprises/headaches getting that up and running! .NET 7 DiagnosticSource drops support for net461 (bumped to net462), net5.0, & netcoreapp3.1. Presumably because they will all be out of support by the time .NET 7 releases. We will need to update the targets in most (all?) of our csproj files in order to consume .NET 7. I'm not going to check that in because it will disrupt the 1.2 metrics effort, but I'm checking in the updates I made to preprocessor directives. Should be safe to do now and save a little bit of effort when it comes time to do that upgrade.