Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Guard Methods to make their action more explicit #2762

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Renaming Guard Methods to make their action more explicit #2762

merged 2 commits into from
Jan 12, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Dec 28, 2021

Fixes #2501 (comment)
Use more explicit method names for Guard.cs
Thanks @pellared and @reyang !

New Throw Method Names

  • ThrowIfNull
  • ThrowIfNullOrEmpty
  • ThrowIfNullOrWhitespace
  • ThrowIfZero
  • ThrowIfInvalidTimeout
  • ThrowIfOutOfRange

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #2762 (ab65a2d) into main (fc35311) will increase coverage by 0.07%.
The diff coverage is 92.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
+ Coverage   83.78%   83.85%   +0.07%     
==========================================
  Files         251      251              
  Lines        8835     8835              
==========================================
+ Hits         7402     7409       +7     
+ Misses       1433     1426       -7     
Impacted Files Coverage Δ
...rter.InMemory/InMemoryExporterLoggingExtensions.cs 0.00% <0.00%> (ø)
...y.Exporter.Prometheus/PrometheusExporterOptions.cs 66.66% <0.00%> (ø)
...c/OpenTelemetry/Logs/OpenTelemetryLoggerOptions.cs 72.72% <50.00%> (ø)
...c/OpenTelemetry/Metrics/MeterProviderExtensions.cs 30.30% <50.00%> (ø)
.../OpenTelemetry/Metrics/MeterProviderBuilderBase.cs 88.23% <60.00%> (ø)
...rc/OpenTelemetry/Trace/TracerProviderExtensions.cs 40.00% <66.66%> (ø)
...OpenTelemetry.Shims.OpenTracing/SpanBuilderShim.cs 91.48% <88.88%> (ø)
src/OpenTelemetry.Api/Baggage.cs 100.00% <100.00%> (ø)
.../Context/Propagation/CompositeTextMapPropagator.cs 83.33% <100.00%> (ø)
src/OpenTelemetry.Api/Context/RuntimeContext.cs 90.90% <100.00%> (ø)
... and 69 more

@mic-max mic-max marked this pull request as ready for review January 12, 2022 14:06
@mic-max mic-max requested a review from a team January 12, 2022 14:06
@cijothomas cijothomas merged commit 18d73c5 into open-telemetry:main Jan 12, 2022
@mic-max mic-max deleted the rename-guard-methods branch January 12, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants