Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary using statements #2727

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 7, 2021

Changes

  • Remove unnecessary using statements

@utpilla utpilla requested a review from a team December 7, 2021 00:20
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #2727 (ad4ac2c) into main (33f3596) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   83.81%   83.78%   -0.04%     
==========================================
  Files         250      250              
  Lines        8824     8824              
==========================================
- Hits         7396     7393       -3     
- Misses       1428     1431       +3     
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️

@cijothomas
Copy link
Member

/easycla

1 similar comment
@cijothomas
Copy link
Member

/easycla

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/difficultcla

@utpilla
Copy link
Contributor Author

utpilla commented Dec 7, 2021

/difficultcla
😂😂

@mic-max
Copy link
Contributor

mic-max commented Dec 13, 2021

Does the .editorconfig and build/Common.props not apply to /docs, /examples, or /test?
I thought the change here to those files would have prevented us from ever letting unnecssary using statements into the main branch since in PR builds warnings are treated as errors I believe.

@cijothomas
Copy link
Member

/easycla

@cijothomas
Copy link
Member

Does the .editorconfig and build/Common.props not apply to /docs, /examples, or /test? I thought the change here to those files would have prevented us from ever letting unnecssary using statements into the main branch since in PR builds warnings are treated as errors I believe.

It appears so. Might need some tweaks to make it apply to entire repo.

@cijothomas cijothomas merged commit 87f66d3 into open-telemetry:main Dec 14, 2021
@utpilla utpilla deleted the utpilla/Remove-unnecessary-using-statements branch November 23, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants