-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OtlpExporter: HttpClientFactory option #2696
OtlpExporter: HttpClientFactory option #2696
Conversation
...ry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/OtlpHttpMetricsExportClient.cs
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2696 +/- ##
==========================================
+ Coverage 82.95% 84.05% +1.09%
==========================================
Files 250 251 +1
Lines 8705 8778 +73
==========================================
+ Hits 7221 7378 +157
+ Misses 1484 1400 -84
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpTraceExporterHelperExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Haven't thought it through, but this may actually be of use to the gRPC based exporters as well. At least for compilation that uses the Grpc.Net.Client library, you can set the underlying HttpClient to use. Allows for more sophisticated configuration of the channel. https://grpc.github.io/grpc/csharp-dotnet/api/Grpc.Net.Client.GrpcChannelOptions.html#Grpc_Net_Client_GrpcChannelOptions_HttpClient
Closes #2522
Changes
HttpClientFactory
option we have onJaegerExporterOptions
&ZipkinExporterOptions
toOtlpExporterOptions
.IHttpClientFactory
integration whenIDeferredTracerProviderBuilder
/IDeferredMeterProviderBuilder
is used.HttpProtobuf
protocol inOtlpMetricExporter
.TODOs
CHANGELOG.md
updated for non-trivial changes