-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include endpoint URI in connection failure events #2686
Conversation
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
I'd love to update the public API docs but would need some more help. The contribution guide mentions to use intellisense, but do you mean start typing and use the autocomplete or does it support this kind of generation? |
...ry.Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs
Show resolved
Hide resolved
...metry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/BaseOtlpHttpExportClient.cs
Show resolved
Hide resolved
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
There is no public API change in this PR, so no need of public API doc update. |
Codecov Report
@@ Coverage Diff @@
## main #2686 +/- ##
==========================================
- Coverage 82.95% 82.93% -0.03%
==========================================
Files 249 249
Lines 8703 8704 +1
==========================================
- Hits 7220 7219 -1
- Misses 1483 1485 +2
|
Signed-off-by: Tom Kerkhove <[email protected]>
I didn't add any additional testing since Any guidance on the testing side on what I should improve? |
Changes
Include endpoint URI in connection failure events to help improve troubleshooting to ensure that the called endpoint is configured correctly.
For significant contributions please make sure you have completed the following items:
[ ] Design discussion issue #[ ] Changes in public API reviewedDid not update public API given the event source is internal.