Add MetricReaderType to OtlpExporterOptions #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
- Coverage 82.94% 82.87% -0.07%
==========================================
Files 249 249
Lines 8688 8691 +3
==========================================
- Hits 7206 7203 -3
- Misses 1482 1488 +6
|
joaopgrassi
approved these changes
Nov 24, 2021
cijothomas
reviewed
Nov 24, 2021
| @@ -68,7 +68,8 @@ internal static object Run(MetricsOptions options) | |||
| providerBuilder | |||
| .AddOtlpExporter(o => | |||
| { | |||
| o.MetricExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds; | |||
| o.MetricReaderType = MetricReaderType.Periodic; | |||
There was a problem hiding this comment.
this is not required, right? its the default already...
There was a problem hiding this comment.
okay to leave it to make it obvious in the examples.
cijothomas
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #2648