Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PrometheusExporter example #2649

Merged

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 20, 2021

Related to #2593.

@reyang reyang requested a review from a team November 20, 2021 05:00
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #2649 (affae9e) into main (81cc49c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
+ Coverage   81.30%   81.31%   +0.01%     
==========================================
  Files         245      245              
  Lines        8645     8645              
==========================================
+ Hits         7029     7030       +1     
+ Misses       1616     1615       -1     
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 86.98% <0.00%> (+0.68%) ⬆️

@cijothomas cijothomas merged commit 31a2d67 into open-telemetry:main Nov 20, 2021
@reyang reyang deleted the reyang/improve-prometheus-example branch November 20, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants