Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements #2612

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Test improvements #2612

merged 3 commits into from
Nov 16, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 16, 2021

No description provided.

@reyang reyang requested a review from a team November 16, 2021 00:30
@reyang reyang mentioned this pull request Nov 16, 2021
Merged
3 tasks
@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #2612 (81e3cbe) into main (e871c27) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
+ Coverage   80.22%   80.38%   +0.15%     
==========================================
  Files         257      257              
  Lines        8844     8838       -6     
==========================================
+ Hits         7095     7104       +9     
+ Misses       1749     1734      -15
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 80.88% <100.00%> (ø)
...ometheus/Implementation/PrometheusSerializerExt.cs 37.33% <100.00%> (+4.00%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
....Prometheus/Implementation/PrometheusSerializer.cs 72.16% <0.00%> (+9.27%) ⬆️

CodeBlanch
CodeBlanch approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit f09f62b into open-telemetry:main Nov 16, 2021
@reyang reyang deleted the reyang/prometheus-test branch November 16, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reyang @alanwest @CodeBlanch @cijothomas