Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused new (found in disassembly in public nuget) #2550

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

ndrwrbgs
Copy link
Contributor

internal static void AddBatch(this ExportLogsServiceRequest request, Resource processResource, in Batch<OpenTelemetry.Logs.LogRecord> logRecordBatch)
{
	new Dictionary<string, InstrumentationLibraryLogs>();
	ResourceLogs resourceLogs = new ResourceLogs
	{
		Resource = processResource
	};

Fixes #.

Changes

This may hint that there's a logic library further down, that was supposed to be using this field. Original author, please review with care as I did not review closely the intent.

```
internal static void AddBatch(this ExportLogsServiceRequest request, Resource processResource, in Batch<OpenTelemetry.Logs.LogRecord> logRecordBatch)
{
	new Dictionary<string, InstrumentationLibraryLogs>();
	ResourceLogs resourceLogs = new ResourceLogs
	{
		Resource = processResource
	};```
@ndrwrbgs ndrwrbgs requested a review from a team October 30, 2021 04:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@reyang
Copy link
Member

reyang commented Oct 30, 2021

@ndrwrbgs thank you for the contribution! Would you clear the EasyCLA?

@ndrwrbgs
Copy link
Contributor Author

Already done

@ndrwrbgs
Copy link
Contributor Author

Valid completeness warnings in build


D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\Implementation\LogRecordExtensions.cs(17,1): error IDE0005: Using directive is unnecessary. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj]
D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\Implementation\LogRecordExtensions.cs(17,1): error IDE0005: Using directive is unnecessary. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj]
D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\Implementation\LogRecordExtensions.cs(17,1): error IDE0005: Using directive is unnecessary. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj]
D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\Implementation\LogRecordExtensions.cs(17,1): error IDE0005: Using directive is unnecessary. [D:\a\opentelemetry-dotnet\opentelemetry-dotnet\src\OpenTelemetry.Exporter.OpenTelemetryProtocol\OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj]

I'll take a look later when I can actually check out the project in an IDE

@ndrwrbgs ndrwrbgs marked this pull request as draft October 30, 2021 04:28
@ndrwrbgs ndrwrbgs marked this pull request as ready for review October 30, 2021 19:23
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #2550 (bf8741b) into main (1d16b0a) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2550      +/-   ##
==========================================
- Coverage   80.83%   80.83%   -0.01%     
==========================================
  Files         254      254              
  Lines        8553     8552       -1     
==========================================
- Hits         6914     6913       -1     
  Misses       1639     1639              
Impacted Files Coverage Δ
...etryProtocol/Implementation/LogRecordExtensions.cs 0.00% <ø> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️

@ndrwrbgs
Copy link
Contributor Author

The failure appears unrelated to the PR. What are the next steps/process for merging in this repository?
Thanks again for your time reviewing this 😊

@alanwest alanwest merged commit 02f2594 into open-telemetry:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants