-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused new (found in disassembly in public nuget) #2550
Conversation
``` internal static void AddBatch(this ExportLogsServiceRequest request, Resource processResource, in Batch<OpenTelemetry.Logs.LogRecord> logRecordBatch) { new Dictionary<string, InstrumentationLibraryLogs>(); ResourceLogs resourceLogs = new ResourceLogs { Resource = processResource };```
|
@ndrwrbgs thank you for the contribution! Would you clear the EasyCLA? |
Already done |
Valid completeness warnings in build
I'll take a look later when I can actually check out the project in an IDE |
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
- Coverage 80.83% 80.83% -0.01%
==========================================
Files 254 254
Lines 8553 8552 -1
==========================================
- Hits 6914 6913 -1
Misses 1639 1639
|
The failure appears unrelated to the PR. What are the next steps/process for merging in this repository? |
Fixes #.
Changes
This may hint that there's a logic library further down, that was supposed to be using this field. Original author, please review with care as I did not review closely the intent.