Unit test for metric stream duplication #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2408 +/- ##
==========================================
+ Coverage 80.24% 80.28% +0.04%
==========================================
Files 232 232
Lines 7500 7500
==========================================
+ Hits 6018 6021 +3
+ Misses 1482 1479 -3
|
reyang
reviewed
Sep 23, 2021
| { | ||
| var metricItems = new List<Metric>(); | ||
| int metricCount = 0; | ||
| var metricExporter = new TestExporter<Metric>(ProcessExport); |
There was a problem hiding this comment.
Could we use InMemoryExporter?
Main reason is that we build InMemoryExporter for folks to use in their unit tests, I think we need to use it in our own tests, too.
There was a problem hiding this comment.
Yes. Once #2361 is fixed.
There was a problem hiding this comment.
no. this particular test is not blocked.
Want to switch all the test in this class to use InMemoryExporter together once #2361 is ready.
reyang
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes