Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MetricReader #2385

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Refactor MetricReader #2385

merged 7 commits into from
Sep 20, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 18, 2021 •
edited
Loading

  • Consolidated Flush and Collect.
  • Fixed the flush logic (previously it was marked as TODO: need to hammer this out).

@reyang reyang requested a review from a team September 18, 2021 05:53
@codecov
Copy link

codecov bot commented Sep 18, 2021 •
edited
Loading

Codecov Report

Merging #2385 (cb5135a) into main (58054d1) will increase coverage by 0.17%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2385      +/-   ##
==========================================
+ Coverage   79.75%   79.93%   +0.17%     
==========================================
  Files         231      231              
  Lines        7459     7445      -14     
==========================================
+ Hits         5949     5951       +2     
+ Misses       1510     1494      -16
Impacted Files Coverage Δ
...OpenTelemetry/Metrics/BaseExportingMetricReader.cs 73.33% <ø> (+2.36%) ⬆️
src/OpenTelemetry/Metrics/CompositeMetricReader.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 88.63% <0.00%> (ø)
src/OpenTelemetry/Metrics/MetricReader.cs 62.50% <60.00%> (+6.50%) ⬆️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.85% <0.00%> (-0.79%) ⬇️
...Zipkin/Implementation/ZipkinExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

CodeBlanch
CodeBlanch approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pellared
pellared approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just two nitty comments.

src/OpenTelemetry/Metrics/MetricReader.cs Show resolved Hide resolved
src/OpenTelemetry/Metrics/MetricReader.cs Outdated Show resolved Hide resolved
@cijothomas cijothomas merged commit 1d63b31 into open-telemetry:main Sep 20, 2021
@reyang reyang deleted the reyang/metrics-refactor branch September 20, 2021 18:54
@reyang reyang mentioned this pull request Sep 20, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@cijothomas cijothomas cijothomas approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reyang @pellared @cijothomas @CodeBlanch