Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copy MetricPoint in exporter #2338

Merged

Conversation

cijothomas
Copy link
Member

Actually applying changes from #2321 to each exporters.

@cijothomas cijothomas requested a review from a team September 10, 2021 23:38
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #2338 (2d471c7) into main (3e0c451) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2338   +/-   ##
=======================================
  Coverage   80.65%   80.65%           
=======================================
  Files         229      229           
  Lines        7304     7304           
=======================================
  Hits         5891     5891           
  Misses       1413     1413           
Impacted Files Coverage Δ
...tryProtocol/Implementation/MetricItemExtensions.cs 39.52% <20.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...Zipkin/Implementation/ZipkinExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas cijothomas merged commit 2ef0179 into open-telemetry:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants