Aligns exporting pipeline with SDK spec #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
changed the title
lmolkova
force-pushed
the
spanProcessor
branch
from
3751a86 to
1445643
Compare
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
| { | ||
| this.worker.RegisterHandler(name, handler); | ||
| /// <summary> | ||
| /// Batch is successfully exported. |
There was a problem hiding this comment.
Why batch is in the name of an enum in the abstract exporter?
There was a problem hiding this comment.
exporters always export list of spans. Batch vs non-batch exists only in processor.
| { | ||
| protected readonly SpanExporter Exporter; | ||
|
|
||
| protected SpanProcessor(SpanExporter exporter) |
There was a problem hiding this comment.
can processors be chained?
There was a problem hiding this comment.
tracer will have multiple processors, they are executed sequentially (not chained) per spec.
We'll handle processor registration in #226
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| namespace OpenTelemetry.Trace.Export.Test |
There was a problem hiding this comment.
thank you for adding a test
SergeyKanzhelev
approved these changes
Sep 23, 2019
This was referenced Sep 26, 2019
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec, Tracer should have processor(s): simple and batching.
Each processor has exporter which can export batch and shutdown
this change aligns implementation with spec (partially) and removes extra abstractions left from census.
Depends on #221, #222Fixes #120, #223, #225
More to do: #224 (batching processor), #226 (multi-processor registration)