Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Microsoft.AspNet.TelemetryCorrelation -> OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule #2238

Conversation

CodeBlanch
Copy link
Member

Part of #2222.

Changes

  • Rename Microsoft.AspNet.TelemetryCorrelation -> OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule
  • Updated namespaces (went with OpenTelemetry.Instrumentation.AspNet inside the project, looking for feedback on this)
  • Added project to the solution
  • Updated references in projects, READMEs, & [web.]config files

…entation.AspNet.TelemetryHttpModule. Added project to the solution + updated references & namespaces.
@CodeBlanch CodeBlanch requested a review from a team August 6, 2021 04:25
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodeBlanch
Copy link
Member Author

@cijothomas @reyang @alanwest How do you guys feel about using OpenTelemetry.Instrumentation.AspNet as the namespace inside of OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule? My thinking was, since the two libs are very closely related, we could save users with both from having an additional namespace popping up in their IDE.

@reyang
Copy link
Member

reyang commented Aug 6, 2021

@cijothomas @reyang @alanwest How do you guys feel about using OpenTelemetry.Instrumentation.AspNet as the namespace inside of OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule? My thinking was, since the two libs are very closely related, we could save users with both from having an additional namespace popping up in their IDE.

Yeah, I noticed that you've picked the same namespace and I +1 on this.
I think this module is not going to be widely used by the end user, so I don't have strong opinion.

@CodeBlanch CodeBlanch merged commit 65c09ff into open-telemetry:aspnet-telemetrycorrelation Aug 7, 2021
@CodeBlanch CodeBlanch deleted the aspnet-telemetrycorrelation-rename branch August 7, 2021 05:02
cijothomas pushed a commit that referenced this pull request Aug 11, 2021
…entation.AspNet.TelemetryHttpModule. Added project to the solution + updated references & namespaces. (#2238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants