-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS and OTEL_EXPORTER_OTLP_TIMEOUT env vars #2188
Merged
cijothomas
merged 9 commits into
open-telemetry:main
from
dszmigielski:otlp-exporter-env-variables
Jul 27, 2021
Merged
Add support for OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS and OTEL_EXPORTER_OTLP_TIMEOUT env vars #2188
cijothomas
merged 9 commits into
open-telemetry:main
from
dszmigielski:otlp-exporter-env-variables
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RS and OTEL_EXPORTER_OTLP_TIMEOUT env variables
CodeBlanch
reviewed
Jul 26, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Jul 27, 2021
cijothomas
reviewed
Jul 27, 2021
...ry.Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jul 27, 2021
...ry.Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs
Outdated
Show resolved
Hide resolved
…n/OpenTelemetryProtocolExporterEventSource.cs
…n/OpenTelemetryProtocolExporterEventSource.cs
Codecov Report
@@ Coverage Diff @@
## main #2188 +/- ##
=======================================
Coverage 74.65% 74.66%
=======================================
Files 217 217
Lines 6948 6974 +26
=======================================
+ Hits 5187 5207 +20
- Misses 1761 1767 +6
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1453.
This feature is important so that we can reuse the SDK in https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation.
Changes
The OtlpExporterOptions defaults can be overridden using
OTEL_EXPORTER_OTLP_ENDPOINT
,OTEL_EXPORTER_OTLP_HEADERS
andOTEL_EXPORTER_OTLP_TIMEOUT
environmental variables as defined in the specification.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes