Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - ignore SetStatus is the status is already set to Ok #2032

Closed
wants to merge 1 commit into from

Conversation

reyang
Copy link
Member

@reyang reyang commented May 4, 2021

This is a POC for the option2 of this spec discussion.

Update: this PR now depends on the specification PR to be merged and released - open-telemetry/opentelemetry-specification#1685.

Changes

  • If the status is set to Ok, freeze the status and not allow future updates (including both the status code and description).

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2032 (89de005) into main (c28efc3) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   83.90%   83.87%   -0.03%     
==========================================
  Files         192      192              
  Lines        6195     6197       +2     
==========================================
  Hits         5198     5198              
- Misses        997      999       +2     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 89.47% <50.00%> (-4.65%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (-5.89%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If spec approves this decision, then we need to ask .NET Runtime to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants