Initial implementation of the OpenTracing bridge. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwiese
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably: -Missing the Binary injection/extraction of the span context. This doesn't exist with the current implementation of OpenTracing yet. -Missing explicit timestamps for calls to OpenTracing ISpan::Log. -Missing explicit timestamps for calls to OpenTracing ISpan::Finish -Various calls to set/get baggage are not implemented. Requires OpenTelemetry DistributedContext to be finalized. Other oddities worth nothing: -The SpanBuilderShim has some conditional code for calling OpenTel SetCreateChild(true|false) -The ScopeManagerShim is actively tracking scopes returned by calls to OpenTel WithSpan and associated those with the OpenTel ISpan used when calling WithSpan. I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend. The included tests are unit tests only; no E2E tests.
pcwiese
force-pushed
the
pwiese/opentracing-bridge
branch
from
b90770b to
4ce8cc0
Compare
austinlparker
approved these changes
Sep 5, 2019
| @@ -54,7 +54,7 @@ public SpanContext Extract<T>(T carrier, Func<T, string, IEnumerable<string>> ge | |||
| return SpanContext.Blank; | |||
| } | |||
|
|
|||
| var traceparent = traceparentCollection.First(); | |||
| var traceparent = traceparentCollection?.First(); | |||
There was a problem hiding this comment.
I don't understand why this change is in this PR?
|
it seems @pcwiese is out on the leave. I'll merge it before it diverges from master |
sywhang
pushed a commit
to sywhang/opentelemetry-dotnet
that referenced
this pull request
Sep 6, 2019
This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably: -Missing the Binary injection/extraction of the span context. This doesn't exist with the current implementation of OpenTracing yet. -Missing explicit timestamps for calls to OpenTracing ISpan::Log. -Missing explicit timestamps for calls to OpenTracing ISpan::Finish -Various calls to set/get baggage are not implemented. Requires OpenTelemetry DistributedContext to be finalized. Other oddities worth nothing: -The SpanBuilderShim has some conditional code for calling OpenTel SetCreateChild(true|false) -The ScopeManagerShim is actively tracking scopes returned by calls to OpenTel WithSpan and associated those with the OpenTel ISpan used when calling WithSpan. I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend. The included tests are unit tests only; no E2E tests.
|
@pcwiese congratulations! |
lmolkova
pushed a commit
that referenced
this pull request
Sep 6, 2019
* Remove ExportComponent from README * Initial implementation of the OpenTracing bridge. (#197) This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably: -Missing the Binary injection/extraction of the span context. This doesn't exist with the current implementation of OpenTracing yet. -Missing explicit timestamps for calls to OpenTracing ISpan::Log. -Missing explicit timestamps for calls to OpenTracing ISpan::Finish -Various calls to set/get baggage are not implemented. Requires OpenTelemetry DistributedContext to be finalized. Other oddities worth nothing: -The SpanBuilderShim has some conditional code for calling OpenTel SetCreateChild(true|false) -The ScopeManagerShim is actively tracking scopes returned by calls to OpenTel WithSpan and associated those with the OpenTel ISpan used when calling WithSpan. I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend. The included tests are unit tests only; no E2E tests.
1 task
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
…rces due to exception "The SSL connection could not be established" (open-telemetry#208) * open-telemetry#197 - AWSEKSResourceDetector fails to detect resources due to exception "The SSL connection could not be established" Issue Description: With the current code, it requires an additional step of installing kubernetes self-signed certificate to the trusted store as .NET core expects them to the trsuted store to make a secure connection. Fix Provided: ServerCertificationValidationProvider - Safely loads the certificate to the trusted collection along with ServerSideValidation. This would avoid the unnecessary step of installing the certificate manually. Handler - Creates HttpClientHandler with client certificate. (cherry picked from commit 41e68d3c55ec3c61604a9c5ba07242747f5a17e9) * PR Review Comments (cherry picked from commit 0b5d9a9360c35e5db93f92e22fbea5f43b1adfd0) * Address PR comments (cherry picked from commit 4aa1c6213aabc78e60b841632ebc4db03cd4986c) * Remove unused import * Added Unit Tests * Removed unused directive * Added Trait for codecov build * Use temporary files to store test certificate * Fixed File Access Issue in Unit Test * Use TempFileName for Unit Tests * Added Debug logging for build test Fixed For loop tries * Revert "Added Debug logging for build test" This reverts commit b9823252f545324efc0031b0b654462085cb1f68. * Fixed tries logic in for loop Co-authored-by: Prashant Srivastava <[email protected]> Co-authored-by: Igor Kiselev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, where possible, a direct port of the current Java shim. There are some holes/TODOS. Notably:
Other oddities worth nothing:
I tested this shim against an ASP.NET Core 3 Preview 8 service wired up with OpenTracing netcore and grpc collectors and exporting to Jaeger backend.
The included tests are unit tests only; no E2E tests.