-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP log exporter #1964
OTLP log exporter #1964
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1964 +/- ##
==========================================
- Coverage 80.11% 79.29% -0.83%
==========================================
Files 251 254 +3
Lines 8289 8375 +86
==========================================
Hits 6641 6641
- Misses 1648 1734 +86
|
Any news about that ? Does anyone know if this lib should be changed il the future ? Else we just need a static mapping in this PR. |
Hi guys! Great job! any update on this? |
Hi all! Cheers! |
It may not take too much to get this into a usable state. However, currently folks are primarily focused on supporting metrics, so it may be difficult get an eye on further logs support in the near term. |
Hi, any update about this? |
Hi everyone!, any updates on this? |
Is there any update on the log exporter? |
Hi all, can help us with this improvement? |
…y-dotnet into alanwest/otlp-logs
I've retargeted this PR to a feature branch and set it ready to review. We could consider doing a pre-release version with the this functionality. Another option we discussed a couple months back in the SIG meeting was the idea of hosting this exporter in the OpenTelemetry.Contrib.Preview package - but I liked this idea less after giving it a try. It required copying too many internal dependencies from the OpenTelemetry.Exporter.OpenTelemetryProtocol project to make work. Also, when #2316 lands, it will require a little refactor to the log exporter and also some work to make it work with http/protobuf transport. If we land this to a feature branch these things could be a follow up. |
We discussed this in todays SIG, and agreed to make this a separate package (pre-release tag), agreeing to the original idea below:
|
Maybe a quick & small topic that I want to get some ideas: are we thinking about having a single TCP connection that we can export logs/traces/metrics to OpenTelemetry Collector? Put the question in a different way - if I use logs/metrics/traces and I don't want to have 3 OTLP exporters each managing their own connection / authz, what do I do? |
Good question, I've had this thought in the back of my mind as well. Opened an issue (#2426) and shared some initial brainstorming. |
...Exporter.OpenTelemetryProtocol.Logs/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs.csproj
Show resolved
Hide resolved
...Exporter.OpenTelemetryProtocol.Logs/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs.csproj
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogsExporter.cs
Outdated
Show resolved
Hide resolved
...enTelemetry.Exporter.OpenTelemetryProtocol/.publicApi/netstandard2.1/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
...emetry.Exporter.OpenTelemetryProtocol.Logs/.publicApi/netstandard2.1/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
...ry.Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs
Outdated
Show resolved
Hide resolved
...Exporter.OpenTelemetryProtocol.Logs/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs/OtlpLogExporterHelperExtensions.cs
Outdated
Show resolved
Hide resolved
// limitations under the License. | ||
// </copyright> | ||
|
||
#if NET461 || NETSTANDARD2_0 || NETSTANDARD2_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this conditional at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a comment about the need for conditional targetting.
Logs exporter recently landed here: open-telemetry#1964
* Mention logs as an option for OTLP exporter Logs exporter recently landed here: #1964 * Mention logs support, requiring separate package * Relative link within repo * Create README.md * Fix relative path and line length * Fix relative path * NuGet badges Co-authored-by: Alan West <[email protected]> * Use a file name to fix path warning * Prereq is implicit already w/NuGet dependency Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Alan West <[email protected]>
This is a first cut at an OTLP log exporter. It was relatively simple to do a proof-of-concept for this. Much of the code is nearly the same as the trace exporter. As such, there's definitely an opportunity to abstract out common functionality between traces and logs (likely benefitting metrics as well). I'll work on this.
Code duplication aside, I wanted to put this PR out there beginning a discussion of how we might ship this functionality. Currently, I have the implementation in the
OpenTelemetry.Exporter.OpenTelemetryProtocol
project. However, this cannot ship as a regular release until logs are deemed stable.There's a couple options:
OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs
- and ship this as a prerelease.