Update HttpInListener to add gRPC tags - By creating a new activity with the OperationName used by the framework

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs

@@ -98,7 +98,7 @@ public override void OnStartActivity(Activity activity, object payload)
                     // Starting the new activity make it the Activity.Current one.
                     newOne.Start();
 
-                    newOne.SetTag("IsCreatedByInstrumentation", true);
+                    newOne.SetTag("IsCreatedByInstrumentation", "True");
 
                     // Set IsAllDataRequested to false for the activity created by the framework to only export the sibling activity and not the framework activity
                     activity.IsAllDataRequested = false;
@@ -215,7 +215,7 @@ public override void OnStopActivity(Activity activity, object payload)
                 }
             }
 
-            if (activity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is bool isCreatedByInstrumentation && isCreatedByInstrumentation)
+            if (activity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is "True")
             {
                 // If instrumentation started a new Activity, it must
                 // be stopped here.

test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs

@@ -177,8 +177,8 @@ public async Task SuccessfulTemplateControllerCallUsesParentContext()
             // List of invocations
             // 1. SetParentProvider for TracerProviderSdk
             // 2. OnStart for the activity created by AspNetCore with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn
-            // 3. OnStart for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, true)
-            // 4. OnEnd for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, true)
+            // 3. OnStart for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, "True")
+            // 4. OnEnd for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, "True")
 
             // we should only call Processor.OnEnd once for the sibling activity
             Assert.Single(activityProcessor.Invocations, invo => invo.Method.Name == "OnEnd");
@@ -191,7 +191,7 @@ public async Task SuccessfulTemplateControllerCallUsesParentContext()
 #else
             // ASP.NET Core before 3.x is not W3C aware and hence Activity created by it
             // is always ignored and new one is created by the Instrumentation
-            Assert.True(activity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is bool isCreatedByInstrumentation && isCreatedByInstrumentation);
+            Assert.True(activity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is "True");
 #endif
             Assert.Equal("api/Values/{id}", activity.DisplayName);
 
@@ -242,8 +242,8 @@ public async Task CustomPropagator()
                 // List of invocations on the processor
                 // 1. SetParentProvider for TracerProviderSdk
                 // 2. OnStart for the activity created by AspNetCore with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn
-                // 3. OnStart for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, true)
-                // 4. OnEnd for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, true)
+                // 3. OnStart for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, "True")
+                // 4. OnEnd for the sibling activity created by the instrumentation library with the OperationName: Microsoft.AspNetCore.Hosting.HttpRequestIn and the first tag that is added is (IsCreatedByInstrumentation, "True")
                 Assert.Equal(4, activityProcessor.Invocations.Count);
 
                 var startedActivities = activityProcessor.Invocations.Where(invo => invo.Method.Name == "OnStart");
@@ -261,14 +261,14 @@ public async Task CustomPropagator()
                 Assert.Single(startedActivities, item =>
                 {
                     var startedActivity = item.Arguments[0] as Activity;
-                    return startedActivity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is bool isCreatedByInstrumentation && isCreatedByInstrumentation;
+                    return startedActivity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is "True";
                 });
 
                 // Only the sibling activity is sent to Processor.OnEnd
                 Assert.Single(stoppedActivities, item =>
                 {
                     var stoppedActivity = item.Arguments[0] as Activity;
-                    return stoppedActivity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is bool isCreatedByInstrumentation && isCreatedByInstrumentation;
+                    return stoppedActivity.CheckFirstTag("IsCreatedByInstrumentation", out var tagValue) && tagValue is "True";
                 });
 
                 var activity = activityProcessor.Invocations.FirstOrDefault(invo => invo.Method.Name == "OnEnd").Arguments[0] as Activity;