-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HttpInListener to add gRPC tags - By retrieving gRPC tag values from payload #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
- Coverage 83.77% 83.33% -0.44%
==========================================
Files 187 188 +1
Lines 5967 6134 +167
==========================================
+ Hits 4999 5112 +113
- Misses 968 1022 +54
|
// Set IsAllDataRequested to false for the activity created by the framework to only export the sibling activity and not the framework activity | ||
activity.IsAllDataRequested = false; | ||
|
||
// Make the new one Activity.Current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is misleading. Activity.Current is modified when newOne.Start() is called itself, not at this line.
…rumentation-For-Sibling-Activity-gRPCSpecificCheck
Closing this PR as we are going forward with the approach of creating the new activity with the OperationName used by the framework #1879 |
Fixes #1740
Changes
OnStartActivity
method to get thegrpc.method
value from payload and add the tag to the activitygrpc.status_code
tag to the activity in theOnStopActivity
method of the listener. Need some advice on the best way to obtain the status code from payload.