-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP exporter: Fix TypeInitializationException thrown by exporter #1873
OTLP exporter: Fix TypeInitializationException thrown by exporter #1873
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 83.56% 83.56% -0.01%
==========================================
Files 192 192
Lines 6163 6150 -13
==========================================
- Hits 5150 5139 -11
+ Misses 1013 1011 -2
|
@CodeBlanch @cijothomas @reyang I fairly certain the increase in memory allocated is not due to the code changes here. The new I suspect that the increase in allocation is related to upgrading our dependency to 3.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM I don't think the change is the reason for the perf hit: That all seems perfectly reasonable to me. Assuming it is flowing through that |
Fixes #1854.
Uses new
UnsafeByteOperations.UnsafeWrap
method in Google.Protobuf 3.15+ to avoid additionalbyte[]
allocation.Perf before:
Perf after:
Seems there is a bit of an increase in memory allocated... I will investigate why.