Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[After 1.0 release] Remove code that prints Baggage information in ConsoleExporter #1825

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Feb 10, 2021

Fixes #1824

Changes

  • Removed code that prints Baggage information

This will be merged only after 1.0.0 release.

  • CHANGELOG.md updated for non-trivial changes

@utpilla utpilla requested a review from a team February 10, 2021 02:42
@utpilla utpilla changed the title Remove code that prints incorrect Baggage information in ConsoleExporter Remove code that prints Baggage information in ConsoleExporter Feb 10, 2021
@utpilla utpilla changed the title Remove code that prints Baggage information in ConsoleExporter [After 1.0 release] Remove code that prints Baggage information in ConsoleExporter Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #1825 (425ca7f) into main (416a6c1) will increase coverage by 0.71%.
The diff coverage is 69.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   83.14%   83.86%   +0.71%     
==========================================
  Files         193      187       -6     
  Lines        6005     5955      -50     
==========================================
+ Hits         4993     4994       +1     
+ Misses       1012      961      -51     
Impacted Files Coverage Δ
...nTelemetry.Exporter.Jaeger/Implementation/Batch.cs 84.09% <ø> (+3.65%) ⬆️
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 92.30% <ø> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 47.22% <40.62%> (-10.23%) ⬇️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 85.00% <84.21%> (-0.27%) ⬇️
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.64% <100.00%> (+0.14%) ⬆️
... and 9 more

@cijothomas cijothomas merged commit 79ba42b into open-telemetry:main Feb 10, 2021
@utpilla utpilla deleted the utpilla/Remove-Baggage-From-ConsoleExporter branch February 11, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConsoleExporter should not display Baggage information
2 participants