Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bad Event definition in the OpenTelemetry.Collector.Dependencies EventSource #181

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fixing a bad Event definition in the OpenTelemetry.Collector.Dependencies EventSource #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/OpenTelemetry.Collector.Dependencies/DependenciesCollectorEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ internal class DependenciesCollectorEventSource : EventSource
[NonEvent]
public void ExceptionInCustomSampler(Exception ex)
{
if (Log.IsEnabled(EventLevel.Warning, EventKeywords.All))
if (this.IsEnabled(EventLevel.Warning, EventKeywords.All))
{
this.ExceptionInCustomSampler(ToInvariantString(ex));
}
Expand All @@ -56,10 +56,21 @@ public void NullActivity(string eventName)
this.WriteEvent(3, eventName);
}

[Event(4, Message = "Unknown error processing event '{0}' from handler '{1}', Exception: {2}", Level = EventLevel.Error)]
[NonEvent]
public void UnknownErrorProcessingEvent(string handlerName, string eventName, Exception ex)
{
if (!this.IsEnabled(EventLevel.Error, EventKeywords.All))
{
return;
}

this.UnknownErrorProcessingEvent(handlerName, eventName, ToInvariantString(ex));
}

[Event(4, Message = "Unknown error processing event '{0}' from handler '{1}', Exception: {2}", Level = EventLevel.Error)]
internal void UnknownErrorProcessingEvent(string handlerName, string eventName, string ex)
{
this.WriteEvent(4, handlerName, eventName, ToInvariantString(ex));
this.WriteEvent(4, handlerName, eventName, ex);
}

/// <summary>
Expand Down