ApplicationInsights exporter hangs on Stop: remove redundant Thread.Sleep(minute) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
|
@austinlparker, @discostu105 ping |
austinlparker
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #176
I believe AppInsights metrics exporter is in the very early stage of its life and the whole implementation is subject to change (after metrics spec settles down).
It does Thread.Sleep(minute) between exporting metrics - probably this will also change. For now there is already logic that waits for a minute in shorter intervals allowing cancellation. Just removing wait for a minute.