Application Insights exporter improvements #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Jul 30, 2019
•
lmolkova
commented
- Application insights should not track calls to itself (it is tmp fix, long-term is coming with HttpClient listener should not track calls to well-known internal endpoints #166 )
- Support for internal spans
- Ignore span.kind attribute - opentracing shim should translate it to the Span.Kind - it shouldn't be an exporter concern.
- minor optimizations
lmolkova
requested review from
austinlparker,
discostu105 and
SergeyKanzhelev
as code owners
|
@austinlparker @discostu105 please review |
|
@austinlparker @discostu105 ping? |
SergeyKanzhelev
approved these changes
Aug 2, 2019
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
* open-telemetry#172 Resource detectors for Docker
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.