Fix RedisProfilerEntryToActivityConverterTests for UTC offset > 0. #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
force-pushed
the
bugfix/stackexchange-redis-test
branch
from
016f10e to
afc59c7
Compare
eddynaka
approved these changes
Dec 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
- Coverage 82.09% 82.06% -0.03%
==========================================
Files 249 249
Lines 6730 6730
==========================================
- Hits 5525 5523 -2
- Misses 1205 1207 +2
|
cijothomas
approved these changes
Jan 4, 2021
|
Need to rebase before merging. |
|
Can we merge this yet? I cannot give you access to my branch since it's an organization repository unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1679.
The mock was returning a default DateTime i.e. zero from the CommandCreated property. This PR fixes it to return the current time instead. The actual value is not important for the test, but date - timezone offset must not become negative.